fix(caldav): Only track interactions of event organizers#38542
Closed
ChristophWurst wants to merge 1 commit intomasterfrom
Closed
fix(caldav): Only track interactions of event organizers#38542ChristophWurst wants to merge 1 commit intomasterfrom
ChristophWurst wants to merge 1 commit intomasterfrom
Conversation
ChristophWurst
added
bug
3. to review
ChristophWurst
requested review from
JohannesGGE,
hamza221,
kesselb,
marcelklehr and
tcitworld
Member
Author
|
/backport to stable27 |
Member
Author
|
/backport to stable26 |
Member
Author
|
/backport to stable25 |
tcitworld
approved these changes
May 31, 2023
Member
tcitworld
left a comment
tcitworld
left a comment
There was a problem hiding this comment.
Should we also limit to events with a future DTSTART? So that past events don't trigger interactions (might be complicated with recurrences).
Member
Author
|
I'll leave that for another PR 🙈 |
Member
Author
|
@JohannesGGE @hamza221 reviews pls |
hamza221
approved these changes
Jun 15, 2023
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
fix/caldav/event-organizer-interaction
branch
from
1bace90 to
34d12a7
Compare
Contributor
|
If I understand it correctly, normal invitations (adding an event with attendees) and imports of events where the organizer is me, should appear in recently contacted, right? On master, that's the case, in this PR nothing appears in recently contacted :( |
Member
Author
|
I'll test that another time! |
ChristophWurst
added
2. developing
Merged
Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Imported events can have attendees to and we wrongly capture them as interactions. Only if the owner of the event is organizer it is their interaction. Anything else can be ignored.
TODO
Checklist