Update icewind/streams to 0.7.7 in files_external#38195
Merged
Conversation
…files_external Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
icewind1991
requested changes
May 11, 2023
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
provokateurin
approved these changes
May 11, 2023
come-nc
force-pushed
the
fix/update-icewind-streams-in-files-external
branch
from
9385bc5 to
b0f072d
Compare
5 tasks
Merged
icewind1991
approved these changes
May 12, 2023
4 tasks
come-nc
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Solves psalm issues about return types in files_external.
A bit weird that we have icewind/streams is two places but it’s a dependency of icewind/smb which is only pulled in files_external, so not sure this is fixable.
Checklist