fix(user_status): Also delete backup status when reverting a hard-cod…#38180
Closed
nickvergessen wants to merge 1 commit intomasterfrom
Closed
fix(user_status): Also delete backup status when reverting a hard-cod…#38180nickvergessen wants to merge 1 commit intomasterfrom
nickvergessen wants to merge 1 commit intomasterfrom
Conversation
…ed status Signed-off-by: Joas Schilling <coding@schilljs.com>
Merged
Merged
Member
Author
|
cc @miaulalala thoughts? |
miaulalala
approved these changes
Dec 19, 2023
Contributor
miaulalala
left a comment
There was a problem hiding this comment.
Logic looks sound to me.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ed status
Summary
I see how this could help, but while trying to test it, I was unable to reproduce the original issue and when digging further I found:
server/apps/dav/lib/BackgroundJob/UserStatusAutomation.php
Lines 164 to 165 in c3c3dcb
which should prevent the original issue already.
So at the moment I'm unsure if we should apply the patch or first wait until we know how it happens so we can write a test for it.
But I didn't want to loose the idea, so here is a draft PR never the less.
Checklist