Remove job from oc_jobs when the file is not findable#37937
Merged
Conversation
artonge
added
enhancement
3. to review
artonge
requested review from
a team,
ArtificialOwl,
blizzz and
icewind1991
and removed request for
a team
solracsf
reviewed
Apr 26, 2023
icewind1991
approved these changes
May 1, 2023
When an application is disabled, or when a background jobs is removed by the app developer, then the job won't be found. In those cases, it makes sense to remove those jobs from oc_job. Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/feat/remove_non_existing_jobs
branch
from
1d5ad29 to
8ad2f34
Compare
Merged
blizzz
approved these changes
May 3, 2023
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an application is disabled, or when a background jobs is removed by the app developer, then the job won't be found at execution time.
In those cases, we return null, but it makes sense to remove those jobs from oc_job.
If the app was disabled, the job will be re-added if the app is enabled again.