Scale ocdialog based on screen size to contain more information on big screens#37773
Closed
SuperSandro2000 wants to merge 1 commit intonextcloud:masterfrom
SuperSandro2000:ocdialog-bigger
Closed
Scale ocdialog based on screen size to contain more information on big screens#37773SuperSandro2000 wants to merge 1 commit intonextcloud:masterfrom SuperSandro2000:ocdialog-bigger
SuperSandro2000 wants to merge 1 commit intonextcloud:masterfrom
SuperSandro2000:ocdialog-bigger
Conversation
…g screens Signed-off-by: Sandro Jäckel <[email protected]>
Pytal
reviewed
Apr 18, 2023
Comment on lines
+537
to
+538
| width: '70vw', | ||
| height: '60vh', |
Member
There was a problem hiding this comment.
Should have a max-width and max-height as well but not sure what values would be best, @jancborchardt @skjnldsv?
Author
There was a problem hiding this comment.
I am not super good in css, should I set the following:
Suggested change
| width: '70vw', | |
| height: '60vh', | |
| mix-width: '70vw', | |
| max-width: '70vw', | |
| min-height: '60vh', | |
| max-height: '60vh', |
or
Suggested change
| width: '70vw', | |
| height: '60vh', | |
| mix-width: '600', | |
| width: '70vw', | |
| min-height: '500', | |
| height: '60vh', |
?
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before:
After:
TODO
Checklist