fix: Skip registering mount points for missing owner node#37736
Closed
juliusknorr wants to merge 1 commit intomasterfrom
Closed
fix: Skip registering mount points for missing owner node#37736juliusknorr wants to merge 1 commit intomasterfrom
juliusknorr wants to merge 1 commit intomasterfrom
Conversation
skjnldsv
approved these changes
Apr 14, 2023
come-nc
approved these changes
Apr 17, 2023
Contributor
come-nc
left a comment
There was a problem hiding this comment.
The root problem is in the move logic no, it should somehow update the share info?
Signed-off-by: Julius Härtl <[email protected]>
f178269 to
8c6703f
Compare
icewind1991
requested changes
Apr 20, 2023
Member
icewind1991
left a comment
There was a problem hiding this comment.
This is a pretty expensive operation to perform for each incoming share and will kill performance for users with a large number of incoming shares.
Member
|
It's probably better to catch this error when the user tries to interact with the broken. That way it doesn't have to run this check for N shares |
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
Merged
Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
Member
Author
|
I lack time to finish this, so I'll close for now. We can reopen anyways if we need. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that we don't show share mount points where the owner node is not available anymore.
steps to reproduce:
🛑 the shared file is still shown but user1 cannot access the file anymore
This still leaves an orphaned share entry but so far I had no luck finding a proper sql query so that we could add this to
server/apps/files_sharing/lib/DeleteOrphanedSharesJob.php
Line 33 in a0f6a65