Conversation
|
@szaimen if you triage a PR and request a review from engineers please make sure the PR is in a reviewable state. To judge the changes here we'd need a description or a linked ticket and before/after screenshots for the visual change. Cheers. |
|
Hi @szaimen and @ChristophWurst, Here are the requested and hopefully sufficient infos for you to acknowledge the changes: Bug report reference: Screenshots before and after the changes as attachment. Please let me know if something is missing! |
JuliaKirschenheuter
left a comment
There was a problem hiding this comment.
Thank you @inet-cologne for fixing this issue!
Not tested but looks good!
This comment was marked as resolved.
This comment was marked as resolved.
…uto-rows:minmax(60px, max-content) to grid-auto-rows:minmax(max-content, max-content). Signed-off-by: Chris <inet.cologne@gmail.com>
a9c171f to
9f330d8
Compare
|
/compile amend / |
|
@inet-cologne please compile and ship changed dist files :) |
|
So basically please rebase, run npm ci and npm run bild and commit the changed files here. Thanks in advance! :) |
|
/rebase |
|
Hi there, Unfortunately the change was not merged in the follower versions of Nextcloud and the rebase produced now a merge conflict. Everything was documented in the related PR. Perhaps someone can assist in resolving the conflict please. |
|
As said above. |
|
Hey @inet-cologne after seeing the few issues we had with the user list, it received a refresh which makes your fix not required anymore! 😉 Thanks for taking the time to create this PR and help Nextcloud, and my apologies for taking this long to update this ticket 🙇 |


Summary
Fix CSS for user list backend to dont overlap entries - from grid-auto-rows:minmax(60px, max-content) to grid-auto-rows:minmax(max-content, max-content).
Checklist