ci(checkers): Fix autoloader (re)generation for extraneous apps

[ChristophWurst]

• Resolves: #

Summary

Running ./build/autoloaderchecker.sh should only touch apps that are part of this repo.

TODO

• Fix the script

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[come-nc]

Any chance to make it stop creating a huge diff when there are no change in files?

[ChristophWurst]

Any chance to make it stop creating a huge diff when there are no change in files?

Composer files are not designed to be commited to git. I can't think of a way to disable any diffs for the generated autoloader code.

If we remove the autoloaders from git and generate them at dev and release time we circumvent the problem.

[go2sh]

Should it be the other way arround? git check-ignore returns 0 if the file is ignored. This will only non ignored files will be skipped like this.

[ChristophWurst]

if git check-ignore apps/mail -q ; then echo "mail should be skipped"; fi -> goes into the conditional branch. This is what we want here. If the file is ignored we want to continue the loop.

[nickvergessen]

Btw this could also replace my local patch for build/image-optimization.sh right:

diff --git a/build/image-optimization.sh b/build/image-optimization.sh
index e559d8552f6..99ac9048e1a 100755
--- a/build/image-optimization.sh
+++ b/build/image-optimization.sh
@@ -33,6 +33,22 @@ function recursive_optimize_images() {
                return
        elif [[ "$DIR_NAME" == "tests" ]]; then
                return
+       elif [[ "$DIR_NAME" == "appsmine" ]]; then
+               return
+       elif [[ "$DIR_NAME" == "appscommunity" ]]; then
+               return
+       elif [[ "$DIR_NAME" == "appsmarketing" ]]; then
+               return
+       elif [[ "$DIR_NAME" == "appspackaged" ]]; then
+               return
+       elif [[ "$DIR_NAME" == "appssubscriptions" ]]; then
+               return
+       elif [[ "$DIR_NAME" == "appssupported" ]]; then
+               return
+       elif [[ "$DIR_NAME" == "appszips" ]]; then
+               return
+       elif [[ "$DIR_NAME" == "apps-action-templates" ]]; then
+               return
        fi
 
        # Optimize all PNGs

But I guess you don't want to add that here, do you?

[ChristophWurst]

Sounds like a neat topic for another PR :)