Block occ commands when in maintenance mode#37365
Closed
miaulalala wants to merge 1 commit intomasterfrom
Closed
Conversation
Signed-off-by: Anna Larch <anna@nextcloud.com>
Contributor
Author
|
Alternative PR by Daniel here: #37178 |
Member
|
We have quite some commands in the docs where we recommend to put the instance into maintenance before (and even turn off the webserver), so I think it's intended that it still works :/ Long running and expensive things like:
And so on come to mind. |
Contributor
Author
Then Daniel's version is the superior approach. Closing this then. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, occ allows execution of commands even while in maintenance mode. The CLI does warn the admin that commands are limited but the execution still works.
This PR adds an exception to block any command that isn't
maintenance:mode --offorstatusas executing other commands is unsafe.(Either this, or remove the misleading sentence as commands can be executed and the database is indeed available - occ user:add for example works).
Checklist