Skip to content

Adjust provisioning API tests after #36665#37361

Merged
nickvergessen merged 1 commit intomasterfrom
fix/noid/display-name-users-controller-test
Mar 23, 2023
Merged

Adjust provisioning API tests after #36665#37361
nickvergessen merged 1 commit intomasterfrom
fix/noid/display-name-users-controller-test

Conversation

@julien-nc
Copy link
Member

@julien-nc julien-nc commented Mar 23, 2023

Sorry, we didn't see the drone failures were because of missing adjustments in tests.

@julien-nc julien-nc added 3. to review Waiting for reviews feature: users and groups tests Related to tests labels Mar 23, 2023
@julien-nc julien-nc added this to the Nextcloud 27 milestone Mar 23, 2023
@szaimen
Copy link
Contributor

szaimen commented Mar 23, 2023

Drone still failing...

@julien-nc
Copy link
Member Author

julien-nc commented Mar 23, 2023

The Nodb failure seems unrelated.

Acceptance header failure:
image

@nickvergessen @szaimen Any clue?

@provokateurin
Copy link
Member

provokateurin commented Mar 23, 2023

The nodb failure is related:
image
It's just not shown when you don't show all the lines (why??).

@szaimen
Copy link
Contributor

szaimen commented Mar 23, 2023

It's just not shown when you don't show all the lines (why??).

bad UX I'd say

@julien-nc julien-nc force-pushed the fix/noid/display-name-users-controller-test branch from f70aa9f to e97abb7 Compare March 23, 2023 16:14
@julien-nc
Copy link
Member Author

julien-nc commented Mar 23, 2023

Nodb is passing now.
@szaimen Should we ignore the acceptance-header failure?

@szaimen
Copy link
Contributor

szaimen commented Mar 23, 2023

@szaimen Should we ignore the acceptance-header failure?

Possibly it is a flaky test...

@julien-nc
Copy link
Member Author

julien-nc commented Mar 23, 2023

@provokateurin Could you check my adjustments in UsersControllerTest.php make sense?

@szaimen
Copy link
Contributor

szaimen commented Mar 23, 2023

@szaimen Should we ignore the acceptance-header failure?

Possibly it is a flaky test...

seems like it passes now?

@julien-nc
adjust tests after #36665
69a1fe2 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc force-pushed the fix/noid/display-name-users-controller-test branch from e97abb7 to 69a1fe2 Compare March 23, 2023 17:17
@julien-nc
Copy link
Member Author

julien-nc commented Mar 23, 2023 •
edited
Loading

seems like it passes now?

🙈

Failing cypress test is related with files_versions. Any chance it is related with #36665?

@nickvergessen nickvergessen merged commit 553b5a5 into master Mar 23, 2023
@nickvergessen nickvergessen deleted the fix/noid/display-name-users-controller-test branch March 23, 2023 20:15
@nickvergessen
Copy link
Member

nickvergessen commented Mar 23, 2023

cypress and accept-header are flaky atm yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@provokateurin provokateurin provokateurin approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: users and groups tests Related to tests

Projects

None yet

Milestone

Nextcloud 27

Development

Successfully merging this pull request may close these issues.

4 participants

@julien-nc @szaimen @provokateurin @nickvergessen