Closed
Conversation
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
juliusknorr
approved these changes
Mar 24, 2023
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
come-nc
reviewed
Mar 27, 2023
Contributor
come-nc
left a comment
There was a problem hiding this comment.
Please avoid mixing changes and refactoring in a single commit like this, it took me a long time to spot the actual change.
Mixing them in a same PR is fine but at least split the commits.
come-nc
reviewed
Mar 27, 2023
Member
Author
Noted. |
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
Merged
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SETEX is depreacted and may be removed: https://redis.io/commands/setex/
PHPredis handles the redirection if needed: https://github.com/phpredis/phpredis#set
(+) small code optimizations
Checklist