Omit "Accessing site insecurely via HTTP." warning if HTTP is secure enough#37330
Merged
szaimen merged 2 commits intonextcloud:masterfrom Apr 18, 2023
Al2Klimov:http-enough
Merged
Omit "Accessing site insecurely via HTTP." warning if HTTP is secure enough#37330szaimen merged 2 commits intonextcloud:masterfrom Al2Klimov:http-enough
szaimen merged 2 commits intonextcloud:masterfrom
Al2Klimov:http-enough
Conversation
szaimen
requested review from
a team,
Pytal,
artonge and
skjnldsv
and removed request for
a team
Contributor
Author
|
Cool that you consider this for NC 27. #37330 (comment) But IMAO there’s some a little more important of mine, a literal security hole IMAO: |
Pytal
reviewed
Mar 27, 2023
Pytal
approved these changes
Apr 4, 2023
Member
|
/rebase |
…enough This is the case for localhost and Tor hidden services. Signed-off-by: Alexander A. Klimov <[email protected]>
Signed-off-by: Alexander A. Klimov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the case for localhost and Tor hidden services.
Checklist