fix: add logging for failed fopen operations that don't throw exceptions#37284
Closed
miaulalala wants to merge 3 commits intostable20from
Closed
fix: add logging for failed fopen operations that don't throw exceptions#37284miaulalala wants to merge 3 commits intostable20from
miaulalala wants to merge 3 commits intostable20from
Conversation
Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
added
2. developing
icewind1991
requested changes
Mar 17, 2023
Contributor
Author
|
Tests are passing on master |
Member
|
What do we do with this PR now? |
Contributor
Author
Nothing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add logging that shows some more file details when the fopen operation returns false.