[stable25] fix(user-management): Fix deleting user in hidden group(s)#37267
Merged
[stable25] fix(user-management): Fix deleting user in hidden group(s)#37267
Conversation
Contributor
Author
|
/compile amend / |
E.g. guest_users Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
enh/36579/new-attempt
branch
from
868cff2 to
07f2ac3
Compare
artonge
reviewed
Mar 16, 2023
Comment on lines
+187
to
+190
| if (!group) { | ||
| console.warn('User group ' + userGroup + ' does not exist during user removal') | ||
| return | ||
| } |
Contributor
There was a problem hiding this comment.
I would map and filter instead of this
Contributor
Author
There was a problem hiding this comment.
@ChristophWurst could you have a look at the comment? Not sure if I can follow Louis' suggestion...
Member
There was a problem hiding this comment.
It gets the same result of undefined. This is a backport. Let's leave it like the original PR and refactoring is desired one can clean up the code on master
artonge
approved these changes
Mar 27, 2023
blizzz
approved these changes
Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #36579