Skip to content

postgresql installation - add quotes around user names#37116

Merged
szaimen merged 1 commit intomasterfrom
enh/37114/add-quotes
Mar 9, 2023
Merged

postgresql installation - add quotes around user names#37116
szaimen merged 1 commit intomasterfrom
enh/37114/add-quotes

Conversation

@szaimen
Copy link
Contributor

@szaimen szaimen commented Mar 7, 2023

fix #37114

@szaimen szaimen added the 2. developing Work in progress label Mar 7, 2023
@szaimen szaimen added this to the Nextcloud 27 milestone Mar 7, 2023
@szaimen
postgresql - add quotes around user names
40edac1 
fix #37114

Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/37114/add-quotes branch from bb04d97 to 40edac1 Compare March 8, 2023 00:03
@szaimen szaimen marked this pull request as ready for review March 8, 2023 00:17
@szaimen szaimen added bug 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 8, 2023
@szaimen
Copy link
Contributor Author

szaimen commented Mar 8, 2023

/backport to stable26

@szaimen
Copy link
Contributor Author

szaimen commented Mar 8, 2023

/backport to stable25

@szaimen
Copy link
Contributor Author

szaimen commented Mar 8, 2023

/backport to stable24

@szaimen szaimen requested review from a team, ArtificialOwl, blizzz and icewind1991 and removed request for a team March 8, 2023 00:17
@szaimen szaimen changed the title postgresql - add quotes around user names postgresql installation - add quotes around user names Mar 8, 2023
@szaimen szaimen mentioned this pull request Mar 8, 2023
Closed
9 tasks
artonge
artonge approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, I would replace " with ' instead of escaping \". But good anyway.

@szaimen
Copy link
Contributor Author

szaimen commented Mar 9, 2023

Nitpick, I would replace " with '

Actually this does not work as Postgres allows only " for user names...

come-nc
come-nc approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check that quotes are not needed around the password as well

@szaimen
Copy link
Contributor Author

szaimen commented Mar 9, 2023

Please double check that quotes are not needed around the password as well

already there:

server/lib/private/Setup/PostgreSQL.php

Line 175 in 61aa097

$query = $connection->prepare("CREATE USER " . addslashes($this->dbUser) . " CREATEDB PASSWORD '" . addslashes($this->dbPassword) . "'");

@szaimen
Copy link
Contributor Author

szaimen commented Mar 9, 2023

CI failure unrelated

@szaimen szaimen merged commit 3dbe108 into master Mar 9, 2023
@szaimen szaimen deleted the enh/37114/add-quotes branch March 9, 2023 09:22
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Mar 9, 2023

The backport to stable26 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Mar 9, 2023

The backport to stable25 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Mar 9, 2023

The backport to stable24 failed. Please do this backport manually.

@szaimen
Copy link
Contributor Author

szaimen commented Mar 9, 2023

/backport to stable26

@szaimen
Copy link
Contributor Author

szaimen commented Mar 9, 2023

/backport to stable25

@szaimen
Copy link
Contributor Author

szaimen commented Mar 9, 2023

/backport to stable24

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Mar 10, 2023

The backport to stable26 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Mar 10, 2023

The backport to stable25 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Mar 10, 2023

The backport to stable24 failed. Please do this backport manually.

@szaimen
Copy link
Contributor Author

szaimen commented Mar 10, 2023

/backport to stable26

@szaimen
Copy link
Contributor Author

szaimen commented Mar 10, 2023

/backport to stable25

@szaimen
Copy link
Contributor Author

szaimen commented Mar 10, 2023

/backport to stable24

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Mar 10, 2023

The backport to stable26 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Mar 10, 2023

The backport to stable25 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Mar 10, 2023

The backport to stable24 failed. Please do this backport manually.

@szaimen
Copy link
Contributor Author

szaimen commented Mar 10, 2023

/backport to stable26

@szaimen
Copy link
Contributor Author

szaimen commented Mar 10, 2023

/backport to stable25

This was referenced Mar 10, 2023
Merged
Merged
@come-nc
Copy link
Contributor

come-nc commented Mar 13, 2023

Please double check that quotes are not needed around the password as well

already there:

server/lib/private/Setup/PostgreSQL.php

Line 175 in 61aa097

$query = $connection->prepare("CREATE USER " . addslashes($this->dbUser) . " CREATEDB PASSWORD '" . addslashes($this->dbPassword) . "'");

How come username needs double quote and password can have single quote ?

@szaimen
Copy link
Contributor Author

szaimen commented Mar 13, 2023 •
edited
Loading

How come username needs double quote and password can have single quote ?

Postgresql limitation 🤷‍♂️
Password is a string and thus can have single quotes. Database user is an entity and thus needs double quotes iirc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@come-nc come-nc come-nc approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@blizzz blizzz Awaiting requested review from blizzz blizzz is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 27

Development

Successfully merging this pull request may close these issues.

[Bug]: When postgres is used, failed to create admin account if username contains hyphen

3 participants

@szaimen @come-nc @artonge