fix: Avoid failing with duplicate checks#36830
Conversation
d1c07c6 to
77e0403
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
77e0403 to
39874cc
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
39874cc to
b695fa7
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
b695fa7 to
10c2c73
Compare
|
Another ping for review here |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
10c2c73 to
06d80ba
Compare
|
/backport to stable27 |
|
/backport to stable26 |
|
/backport to stable25 |
|
/backport to stable24 |
|
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
The backport to stable25 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable25
git pull origin stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
The backport to stable24 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable24
git pull origin stable24
# Create the new backport branch
git checkout -b fix/foo-stable24
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable24More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Summary
When receiving a share the workflow mimetype check the patch was always checked but was an empty string (considered as application/octet-stream then).
There is no need for performing this check anymore here since it is covered within getActualValue these days.
Steps to reproduce:
Before this the file was not visible to the recipient
Note this seems to occur only after #25768
Covered with integration tests by nextcloud/files_accesscontrol#321
Checklist