Set notification email automatically after deleting additional email#36812
Closed
Set notification email automatically after deleting additional email#36812
Conversation
Signed-off-by: Christopher Ng <[email protected]>
artonge
approved these changes
Feb 23, 2023
Contributor
artonge
left a comment
There was a problem hiding this comment.
Would it make sense to do the change on the backend side instead of here?
Merged
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
Merged
Member
I agree with Louis @Pytal :) |
blizzz
approved these changes
Feb 27, 2024
Member
|
also would prefer it on the backend side |
This was referenced Mar 12, 2024
Merged
Merged
Merged
Member
|
Closing this pull request due to lack of recent activity and updates; also seeing the two comments about backend :) |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an additional email is set as the notification email and is deleted, the deleted email will remain as the notification email
This is unexpected behaviour so we fix this by automatically setting the system email as the notification email on deletion
Additional email as notification email
After deletion
Checklist