Avoid extra parenthesis around SQL in IN expressions#36795
Merged
Conversation
Contributor
Author
|
Follow up of nextcloud/spreed#8220 (comment) |
Contributor
Author
|
/backport to stable25 |
Contributor
Author
|
/backport to stable24 |
nickvergessen
approved these changes
Feb 21, 2023
come-nc
requested review from
a team,
ArtificialOwl,
blizzz and
icewind1991
and removed request for
a team
Contributor
Author
|
/rebase |
The expression builder already suround the SQL with parenthesis when using in(), so we must not add another pair, this confuses at least sqlite. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
nextcloud-command
force-pushed
the
fix/remove-erronous-parentheses-in-in-clause
branch
from
9319224 to
7481181
Compare
icewind1991
approved these changes
Feb 21, 2023
This was referenced Feb 21, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The expression builder already suround the SQL with parenthesis when
using in(), so we must not add another pair, this confuses at least
sqlite.
Checklist