New BeforeGroupChangedEvent before setDisplayName on groups#36792
Merged
New BeforeGroupChangedEvent before setDisplayName on groups#36792
Conversation
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
added
enhancement
3. to review
julien-nc
requested review from
a team,
ArtificialOwl,
blizzz,
icewind1991 and
miaulalala
and removed request for
a team
miaulalala
approved these changes
Feb 21, 2023
Contributor
miaulalala
left a comment
miaulalala
left a comment
There was a problem hiding this comment.
To answer your question: I'm not sure, must have been an oversight.
PR looks good!
icewind1991
approved these changes
Feb 21, 2023
Member
Author
|
Thanks for the reviews! Psalm failure is unrelated. |
juliusknorr
added a commit
that referenced
this pull request
Feb 21, 2023
Signed-off-by: Julius Härtl <[email protected]>
Member
|
Drone failure was related. Pushed updated autoloaders in #36799 |
max-nextcloud
added a commit
that referenced
this pull request
Feb 21, 2023
fix: Update autoloader after #36792
Merged
RonaldBarnes
pushed a commit
to RonaldBarnes/NextCloud-server
that referenced
this pull request
Mar 1, 2023
Signed-off-by: Julius Härtl <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This could be useful to let apps prevent renaming of some groups.
This was mentioned by the developers of the OpenProject integration.
@miaulalala Why isn't the old value passed to the
GroupChangedEvent?https://github.com/nextcloud/server/blob/master/lib/private/Group/Group.php#L116