Add back authentication checkbox for mailer settings#36785
Merged
Conversation
miaulalala
requested review from
a team,
ArtificialOwl and
icewind1991
and removed request for
a team
come-nc
reviewed
Feb 21, 2023
szaimen
reviewed
Feb 21, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
miaulalala
force-pushed
the
bug/bring-back-auth-checkbox
branch
from
96bba83 to
1d05efc
Compare
Contributor
|
smtphost seems to be doubled for me now? |
miaulalala
force-pushed
the
bug/bring-back-auth-checkbox
branch
from
1d05efc to
214b910
Compare
Contributor
Author
|
@szaimen should be good now, apologies! |
Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
bug/bring-back-auth-checkbox
branch
from
214b910 to
f0ffa91
Compare
szaimen
approved these changes
Feb 22, 2023
Merged
Merged
| <select name="mail_smtpauthtype" id="mail_smtpauthtype" disabled="disabled"> | ||
| <?php foreach ($mail_smtpauthtype as $authtype => $name): | ||
| $selected = ''; | ||
| if ($authtype == $_['mail_smtpauthtype']): |
Member
There was a problem hiding this comment.
[PHP] Undefined array key "mail_smtpauthtype" at /var/www/cloud.nextcloud.com/nextcloud/apps/settings/templates/settings/admin/additional-mail.php#132 https://nextcloud-gmbh.sentry.io/issues/3973302224
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The symfony mailer refactor removed the authentication checkbox and caused the save for the authentication data to be buggy.
TODO
Checklist
Tests (unit, integration, api and/or acceptance) are includedScreenshots before/after for front-end changes