Skip to content

fix: Avoid throwing errors on public auth page#36780

Merged
juliusknorr merged 2 commits intomasterfrom
bugfix/noid/console-error-share-auth
Feb 20, 2023
Merged

fix: Avoid throwing errors on public auth page#36780
juliusknorr merged 2 commits intomasterfrom
bugfix/noid/console-error-share-auth

Conversation

@juliusknorr
Copy link
Member

Avoid throwing errors on the public share page like:

Cannot read properties of null (reading 'addEventListener')

https://juliushaertl.sentry.io/share/issue/2d96706d8b094bd7b5b780761c11969c/

Checklist

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr requested review from a team, Pytal, artonge, danxuliu, nickvergessen and szaimen and removed request for a team February 20, 2023 08:18
@juliusknorr juliusknorr added this to the Nextcloud 26 milestone Feb 20, 2023
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

Pushed another related fix as styles from core/css were not loaded if called with \OC_Util:.addStyle('core', 'publicshareauth)`.

@juliusknorr juliusknorr merged commit 95eeba8 into master Feb 20, 2023
@juliusknorr juliusknorr deleted the bugfix/noid/console-error-share-auth branch February 20, 2023 11:36
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants