Skip to content

Fix broken search for tags in workflow checks#36754

Merged
nickvergessen merged 2 commits intomasterfrom
bugfix/noid/fix-broken-tag-search-in-workflow-checks
Feb 24, 2023
Merged

Fix broken search for tags in workflow checks#36754
nickvergessen merged 2 commits intomasterfrom
bugfix/noid/fix-broken-tag-search-in-workflow-checks

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 16, 2023 •
edited
Loading

After #36739 we can finally switch to the new component and that also fixes the broken search.
Same issue as in nextcloud/files_automatedtagging#683

Fixes nextcloud/files_accesscontrol#300

Before After
Bildschirmfoto vom 2023-02-24 10-26-41 Bildschirmfoto vom 2023-02-24 10-25-45
Bildschirmfoto vom 2023-02-24 10-26-46 Bildschirmfoto vom 2023-02-24 10-25-50

Checklist

@nickvergessen nickvergessen added this to the Nextcloud 26 milestone Feb 16, 2023
@nickvergessen nickvergessen self-assigned this Feb 16, 2023
@nickvergessen
Copy link
Member Author

nickvergessen commented Feb 16, 2023 •
edited
Loading

/backport 5c432ff to stable25

@nickvergessen nickvergessen mentioned this pull request Feb 21, 2023
Closed
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@nickvergessen
Fix broken search for tags in workflow checks
5c432ff 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
chore(assets): Recompile JS
1f8aeef 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/fix-broken-tag-search-in-workflow-checks branch from c613edc to 1f8aeef Compare February 24, 2023 09:26
@nickvergessen nickvergessen requested review from a team and szaimen and removed request for a team February 24, 2023 09:28
@nickvergessen
Copy link
Member Author

nickvergessen commented Feb 24, 2023

Ready for review

szaimen
szaimen approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@nickvergessen nickvergessen merged commit 9650685 into master Feb 24, 2023
@nickvergessen nickvergessen deleted the bugfix/noid/fix-broken-tag-search-in-workflow-checks branch February 24, 2023 16:20
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 24, 2023
Merged
1 task
@artonge artonge mentioned this pull request Feb 27, 2023
Merged
4 tasks
@blizzz blizzz mentioned this pull request Mar 2, 2023
Merged
@Pytal Pytal mentioned this pull request Mar 2, 2023
Closed
9 tasks
@Pytal Pytal mentioned this pull request Apr 13, 2023
Closed
9 tasks
@maximelehericy maximelehericy mentioned this pull request Aug 26, 2023
Closed
@blizzz blizzz mentioned this pull request Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

@szaimen szaimen szaimen approved these changes

@artonge artonge Awaiting requested review from artonge

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@nickvergessen nickvergessen

Labels

3. to review Waiting for reviews bug feature: workflows

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

Collaborative tags cannot be found

3 participants

@nickvergessen @marcelklehr @szaimen