feat(directediting): Allow opening by file id

[juliusknorr]

Summary

Make sure that it is easy for the notes iOS/Android apps to open files by just knowing the file id. For cases where multiple files with the id are found we prefer the one with update permissions over others.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[AlvaroBrey]

@juliushaertl any possibility to add a capability indicating whether this change is available? Otherwise I'll just check if server version >= 26

[juliusknorr]

Capability added:

[max-nextcloud]

Code looks good.

[max-nextcloud]

Maybe add a test?
I did not find any tests for this controller - but I may have missed them. However there's https://github.com/nextcloud/server/blob/master/tests/lib/DirectEditing/ManagerTest.php which might be fairly easy to extend?

[juliusknorr]

Pushed two further cases to cover the open method with and without a file id.

[mejo-]

Code looks good to me.

[juliusknorr]

Failure unrelated.

[marinofaggiana]

@juliushaertl thanks

[marinofaggiana]

@juliushaertl I have tested it, example:

https://cloud.nextcloud.com/ocs/v2.php/apps/files/api/v1/directEditing/open?fileId=7155303&editorId=text
Response Error 500

[AlvaroBrey]

@juliushaertl I have tested it, example:

https://cloud.nextcloud.com/ocs/v2.php/apps/files/api/v1/directEditing/open?fileId=7155303&editorId=text Response Error 500

You need to also provide path, with the value being the notes storage path (from https://github.com/nextcloud/notes/blob/master/docs/api/v1.md#settings).