perf(dav): Do not call general setupFS on ever dav auth#36626
Merged
juliusknorr merged 1 commit intomasterfrom Feb 9, 2023
Merged
perf(dav): Do not call general setupFS on ever dav auth#36626juliusknorr merged 1 commit intomasterfrom
juliusknorr merged 1 commit intomasterfrom
Conversation
juliusknorr
requested review from
come-nc,
icewind1991,
miaulalala and
nickvergessen
This comment was marked as outdated.
This comment was marked as outdated.
come-nc
approved these changes
Feb 9, 2023
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Would need to be tested carefully, do we know for sure those calls are not needed?
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
perf/dav-auth-setupfs
branch
from
2e27b93 to
7b413a4
Compare
icewind1991
reviewed
Feb 9, 2023
| ->disableOriginalConstructor() | ||
| ->getMock(); | ||
| $user->expects($this->exactly(2)) | ||
| $user->expects($this->exactly(1)) |
Member
There was a problem hiding this comment.
Imo we should get of these exactly calls altogether. Unless the test is actually testing the amount of times a method is called, it's just implementation details leaking out into tests needlessly.
icewind1991
approved these changes
Feb 9, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This could save setting up the full file system and instead use setupForPath. Unsure about possible side effects, webdav works here still, but let's see what the tests have to say.
Local comparison:
Perftesting
Checklist