fix(performance): Only search for auth tokens when the provided login…#36621
Merged
nickvergessen merged 3 commits intomasterfrom Feb 10, 2023
Merged
Conversation
… is long enough Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
3. to review
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
perf/noid/only-check-for-token-when-it-can-actually-be
branch
from
2abdf59 to
7a85a15
Compare
juliusknorr
approved these changes
Feb 9, 2023
Signed-off-by: Joas Schilling <coding@schilljs.com>
come-nc
approved these changes
Feb 9, 2023
nickvergessen
deleted the
perf/noid/only-check-for-token-when-it-can-actually-be
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… is long enough
Summary
All our generated auth tokens have a a fixed length (apart from session id based one which has a minimum). So it's save to assume that shorter strings are not actually valid apptokens we need to look up but the password when basic auth is used.
Additionally a min length check was added to help developers on generating new tokens in the future.
Query count of notifications app integration tests
Checklist