perf(workflowengine): Cache query that is performed on every request#36568
Merged
juliusknorr merged 1 commit intomasterfrom Feb 13, 2023
Merged
perf(workflowengine): Cache query that is performed on every request#36568juliusknorr merged 1 commit intomasterfrom
juliusknorr merged 1 commit intomasterfrom
Conversation
Member
|
labels? |
blizzz
approved these changes
Feb 6, 2023
juliusknorr
force-pushed
the
perf/flow-events
branch
from
4c56630 to
9b8dffa
Compare
Member
Author
|
Sorry, laggy wifi lost them it seem. |
Member
|
Could add test conditions that cache is read, set and unset. |
nickvergessen
approved these changes
Feb 6, 2023
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Had that one on my Todo as well for way too long.
blizzz
added
4. to release
come-nc
approved these changes
Feb 6, 2023
Member
@juliushaertl you are up for that? cough |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
perf/flow-events
branch
from
9b8dffa to
aebf654
Compare
Member
Author
|
Added and also covered getAllConfiguredEvents with a test now. |
Member
Author
|
Failure unrelated |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will save a query for available workflow engine events. The query itself is also not optimal as it does a not equal check on a text field which cannot use an index, however using caching is probably the easiest for now.
Checklist