fix: Only get params from PUT content if possible#36525
Merged
juliusknorr merged 1 commit intomasterfrom Feb 13, 2023
Merged
Conversation
4 tasks
juliusknorr
requested review from
a team,
ArtificialOwl,
blizzz,
icewind1991 and
nickvergessen
and removed request for
a team
nickvergessen
approved these changes
Feb 3, 2023
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
fix/noid/params-put
branch
from
ff750a4 to
dc3916e
Compare
come-nc
approved these changes
Feb 13, 2023
Member
Author
|
Failures unrelated |
Merged
Member
Author
|
/backport to stable25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces #36516 with a more generic approach to not read the request body content if we cannot parse it for parameters
Checklist