Remove failing test that works with mocks only anyway#36504
Merged
nickvergessen merged 1 commit intomasterfrom Feb 3, 2023
Merged
Remove failing test that works with mocks only anyway#36504nickvergessen merged 1 commit intomasterfrom
nickvergessen merged 1 commit intomasterfrom
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
blizzz
approved these changes
Feb 2, 2023
come-nc
approved these changes
Feb 2, 2023
miaulalala
approved these changes
Feb 2, 2023
9 tasks
Member
Author
|
/backport to stable25 |
Member
Author
|
/backport to stable24 |
Member
Author
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since PHPUnit 9.5 this test fails. However the function is so plain:
server/lib/private/Encryption/Util.php
Lines 296 to 299 in f5c361c
That testing it with mocks doesn't really make a lot of sense.
Checklist