Merged
Conversation
The test in admin-settings does not reset the theming. So when it is run before user-background, the "Default cloud background is not rendered" test fails. This makes sure that the theming is reset before running "User default background settings" Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
requested review from
Pytal and
szaimen
and removed request for
a team
4 tasks
skjnldsv
approved these changes
Jan 31, 2023
Member
|
Nice catch! |
Pytal
approved these changes
Jan 31, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test in
admin-settingsdoes not reset the theming. So when it is run beforeuser-background, the"Default cloud background is not rendered"test fails.This makes sure that the theming is reset before running
"User default background settings".@skjnldsv please tell me if I missed something.
Here are two examples: