Fix MigrateBackgroundImages on oracle#36453
Merged
juliusknorr merged 2 commits intomasterfrom Jan 31, 2023
Merged
Conversation
41d373b to
6c42353
Compare
Member
Author
|
/backport to stable25 |
Member
Author
|
Pushed another commit to test if passing PARAM_STR to the eq function also works, as this should cast also looking at the implementation of the OCIExpressionBuilder |
Member
Should adjust the runtime code now as well? |
skjnldsv
approved these changes
Jan 31, 2023
2fd1da7 to
fa49558
Compare
nickvergessen
approved these changes
Jan 31, 2023
Signed-off-by: Julius Härtl <jus@bitgrid.net> test: try with just passing the type to eq which should also cast Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
fa49558 to
ecccff8
Compare
Member
Author
|
Failures unrelated. |
Member
Author
|
/backport ecccff8 to stable25 |
1 task
|
The backport to stable25 failed. Please do this backport manually. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server/apps/theming/lib/Jobs/MigrateBackgroundImages.php
Line 95 in 09099cf
This is the same approach also used in
server/lib/private/AllConfig.php
Lines 497 to 499 in 361e69f
Checklist