Allow php 8.2 by come-nc · Pull Request #36375 · nextcloud/server

come-nc · 2023-01-26T09:05:47Z

Summary

PHP 8.2 is now tested enough to be allowed to be used with master.
There should be no big problems with it, apart from the mailer, until the migration to symfony mailer is finished.

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

ChristophWurst · 2023-01-26T09:56:33Z

PHP 8.2 is now tested enough to be allowed to be used with master.

I've been running it locally for over a week with a modified version check. There are a few deprecation logs here and there but so far I have not found any breakage 👍

ChristophWurst

come-nc · 2023-01-26T09:59:37Z

PHP 8.2 is now tested enough to be allowed to be used with master.

I've been running it locally for over a week with a modified version check. There are a few deprecation logs here and there but so far I have not found any breakage +1

Please do open issues or PR for these deprecation warnings though :-P

Our CI is not catching them it seems, oci on 8.2 is passing while on my test PR it’s not: https://github.com/nextcloud/server/actions/runs/4013641040/jobs/6893223191
I think it’s the ini development thing, I’ll try adding it here.

ChristophWurst · 2023-01-26T10:08:01Z

Please do open issues or PR for these deprecation warnings though :-P

You were too fast. Earlier I checked my logs for dynamic property warnings and you took care of them already in the meantime.

The remainders are

"Creation of dynamic property ScssPhp\\ScssPhp\\Block::$name is deprecated at /nextcloud/3rdparty/scssphp/scssphp/src/Parser.php#854"
"Creation of dynamic property ScssPhp\\ScssPhp\\Compiler\\Environment::$parentStore is deprecated at /nextcloud/3rdparty/scssphp/scssphp/src/Compiler.php#5039"
"Creation of dynamic property ScssPhp\\ScssPhp\\Compiler\\Environment::$selectors is deprecated at /nextcloud/3rdparty/scssphp/scssphp/src/Compiler.php#1872"

nickvergessen

Woohoo, once merged I shall bump all CIs of apps again

come-nc · 2023-02-02T08:13:06Z

/rebase

nickvergessen · 2023-02-02T08:50:31Z

There were 22 errors:

1) Test\Files\Cache\ScannerTest::testBackgroundScan
trim(): Passing null to parameter #1 ($string) of type string is deprecated

/home/runner/work/server/server/lib/private/Files/Storage/Common.php:762
/home/runner/work/server/server/lib/private/Files/Cache/Scanner.php:327
/home/runner/work/server/server/lib/private/Files/Cache/Scanner.php:529
/home/runner/work/server/server/lib/private/Files/Cache/Scanner.php:541
/home/runner/work/server/server/lib/private/Files/Cache/Scanner.php:528
/home/runner/work/server/server/tests/lib/Files/Cache/ScannerTest.php:163

2) Test\Files\ObjectStore\ObjectStoreStorageTest::testMove with data set #0 ('/source.txt', '/target.txt')
md5(): Passing null to parameter #1 ($string) of type string is deprecated

/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:448
/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:364
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:413
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:388
/home/runner/work/server/server/tests/lib/Files/ObjectStore/ObjectStoreStorageTest.php:95

3) Test\Files\ObjectStore\ObjectStoreStorageTest::testMove with data set #1 ('/source.txt', '/target with space.txt')
md5(): Passing null to parameter #1 ($string) of type string is deprecated

/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:448
/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:364
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:413
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:388
/home/runner/work/server/server/tests/lib/Files/ObjectStore/ObjectStoreStorageTest.php:95

4) Test\Files\ObjectStore\ObjectStoreStorageTest::testMove with data set #2 ('/source with space.txt', '/target.txt')
md5(): Passing null to parameter #1 ($string) of type string is deprecated

/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:448
/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:364
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:413
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:388
/home/runner/work/server/server/tests/lib/Files/ObjectStore/ObjectStoreStorageTest.php:95

5) Test\Files\ObjectStore\ObjectStoreStorageTest::testMove with data set #3 ('/source with space.txt', '/target with space.txt')
md5(): Passing null to parameter #1 ($string) of type string is deprecated

/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:448
/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:364
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:413
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:388
/home/runner/work/server/server/tests/lib/Files/ObjectStore/ObjectStoreStorageTest.php:95

6) Test\Files\ObjectStore\ObjectStoreStorageTest::testMove with data set #4 ('/source.txt', '/tärgét.txt')
md5(): Passing null to parameter #1 ($string) of type string is deprecated

/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:448
/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:364
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:413
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:388
/home/runner/work/server/server/tests/lib/Files/ObjectStore/ObjectStoreStorageTest.php:95

7) Test\Files\ObjectStore\ObjectStoreStorageTest::testMove with data set #5 ('/sòurcē.txt', '/target.txt')
md5(): Passing null to parameter #1 ($string) of type string is deprecated

/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:448
/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:364
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:413
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:388
/home/runner/work/server/server/tests/lib/Files/ObjectStore/ObjectStoreStorageTest.php:95

8) Test\Files\ObjectStore\ObjectStoreStorageTest::testMove with data set #6 ('/sòurcē.txt', '/tärgét.txt')
md5(): Passing null to parameter #1 ($string) of type string is deprecated

/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:448
/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:364
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:413
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:388
/home/runner/work/server/server/tests/lib/Files/ObjectStore/ObjectStoreStorageTest.php:95

9) Test\Files\ObjectStore\ObjectStoreStorageTest::testMove with data set #7 ('/single ' quote.txt', '/tar'get.txt')
md5(): Passing null to parameter #1 ($string) of type string is deprecated

/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:448
/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:364
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:413
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:388
/home/runner/work/server/server/tests/lib/Files/ObjectStore/ObjectStoreStorageTest.php:95

10) Test\Files\ObjectStore\ObjectStoreStorageTest::testRenameDirectory
md5(): Passing null to parameter #1 ($string) of type string is deprecated

/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:448
/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:364
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:413
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:388
/home/runner/work/server/server/tests/lib/Files/ObjectStore/ObjectStoreStorageTest.php:113

11) Test\Files\ObjectStore\ObjectStoreStorageTest::testRenameOverWriteDirectory
md5(): Passing null to parameter #1 ($string) of type string is deprecated

/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:448
/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:364
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:413
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:388
/home/runner/work/server/server/tests/lib/Files/ObjectStore/ObjectStoreStorageTest.php:144

12) Test\Files\ObjectStore\ObjectStoreStorageTest::testRenameOverWriteDirectoryOverFile
md5(): Passing null to parameter #1 ($string) of type string is deprecated

/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:448
/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:364
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:413
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:388
/home/runner/work/server/server/tests/lib/Files/ObjectStore/ObjectStoreStorageTest.php:162

13) Test\Files\ObjectStore\ObjectStoreStorageTest::testMoveOverwrite with data set #0 ('/source.txt', '/target.txt')
md5(): Passing null to parameter #1 ($string) of type string is deprecated

/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:448
/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:364
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:413
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:388
/home/runner/work/server/server/tests/lib/Files/Storage/Storage.php:273

14) Test\Files\ObjectStore\ObjectStoreStorageTest::testMoveOverwrite with data set #1 ('/source.txt', '/target with space.txt')
md5(): Passing null to parameter #1 ($string) of type string is deprecated

/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:448
/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:364
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:413
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:388
/home/runner/work/server/server/tests/lib/Files/Storage/Storage.php:273

15) Test\Files\ObjectStore\ObjectStoreStorageTest::testMoveOverwrite with data set #2 ('/source with space.txt', '/target.txt')
md5(): Passing null to parameter #1 ($string) of type string is deprecated

/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:448
/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:364
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:413
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:388
/home/runner/work/server/server/tests/lib/Files/Storage/Storage.php:273

16) Test\Files\ObjectStore\ObjectStoreStorageTest::testMoveOverwrite with data set #3 ('/source with space.txt', '/target with space.txt')
md5(): Passing null to parameter #1 ($string) of type string is deprecated

/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:448
/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:364
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:413
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:388
/home/runner/work/server/server/tests/lib/Files/Storage/Storage.php:273

17) Test\Files\ObjectStore\ObjectStoreStorageTest::testMoveOverwrite with data set #4 ('/source.txt', '/tärgét.txt')
md5(): Passing null to parameter #1 ($string) of type string is deprecated

/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:448
/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:364
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:413
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:388
/home/runner/work/server/server/tests/lib/Files/Storage/Storage.php:273

18) Test\Files\ObjectStore\ObjectStoreStorageTest::testMoveOverwrite with data set #5 ('/sòurcē.txt', '/target.txt')
md5(): Passing null to parameter #1 ($string) of type string is deprecated

/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:448
/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:364
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:413
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:388
/home/runner/work/server/server/tests/lib/Files/Storage/Storage.php:273

19) Test\Files\ObjectStore\ObjectStoreStorageTest::testMoveOverwrite with data set #6 ('/sòurcē.txt', '/tärgét.txt')
md5(): Passing null to parameter #1 ($string) of type string is deprecated

/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:448
/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:364
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:413
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:388
/home/runner/work/server/server/tests/lib/Files/Storage/Storage.php:273

20) Test\Files\ObjectStore\ObjectStoreStorageTest::testMoveOverwrite with data set #7 ('/single ' quote.txt', '/tar'get.txt')
md5(): Passing null to parameter #1 ($string) of type string is deprecated

/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:448
/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:364
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:413
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:388
/home/runner/work/server/server/tests/lib/Files/Storage/Storage.php:273

21) Test\Files\ObjectStore\ObjectStoreStorageTest::testRenameOverWriteFile
md5(): Passing null to parameter #1 ($string) of type string is deprecated

/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:448
/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:364
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:413
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:388
/home/runner/work/server/server/tests/lib/Files/Storage/Storage.php:476

22) Test\Files\ObjectStore\ObjectStoreStorageTest::testPartFile
md5(): Passing null to parameter #1 ($string) of type string is deprecated

/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:448
/home/runner/work/server/server/lib/private/Files/Cache/Cache.php:364
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:413
/home/runner/work/server/server/lib/private/Files/ObjectStore/ObjectStoreStorage.php:388
/home/runner/work/server/server/tests/lib/Files/Storage/Storage.php:647

nickvergessen · 2023-02-02T10:56:47Z

Some debugging was done in #36496

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

This is the only test suite testing 8.1, so adding 8.2 as well Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Signed-off-by: Joas Schilling <coding@schilljs.com>

Otherwise Oracle returns NULL for empty strings and PHP 8.2 throws on null in string functions like trim() and md5() Signed-off-by: Joas Schilling <coding@schilljs.com>

DaphneMuller · 2023-02-21T13:02:04Z

hello @come-nc
Thank you so much for your work on this pull request! This ticket seems to have the tag 'pending documentation'.
Is there any chance you could clarify what documentation is missing? Is this for admins or for app developers?

come-nc added the 2. developing Work in progress label Jan 26, 2023

come-nc added this to the Nextcloud 26 milestone Jan 26, 2023

come-nc self-assigned this Jan 26, 2023

come-nc mentioned this pull request Jan 26, 2023

Support PHP8.2 #32595

Closed

19 tasks

come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 26, 2023

come-nc requested review from a team, ArtificialOwl, PVince81 and blizzz and removed request for a team January 26, 2023 09:51

ChristophWurst added the pending documentation This pull request needs an associated documentation update label Jan 26, 2023

ChristophWurst approved these changes Jan 26, 2023

View reviewed changes

blizzz approved these changes Jan 27, 2023

View reviewed changes

nickvergessen approved these changes Jan 27, 2023

View reviewed changes

blizzz mentioned this pull request Feb 1, 2023

26.0.0 beta 2 #36484

Merged

nextcloud-command force-pushed the enh/allow-php-8.2 branch from b20d421 to f0e88ce Compare February 2, 2023 08:17

nickvergessen mentioned this pull request Feb 2, 2023

feat(CI): Add PHPUnit testing for PHP 8.2 nextcloud/.github#125

Merged

come-nc and others added 5 commits February 2, 2023 12:05

Allow 8.2 in versioncheck

1fec8c0

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Add 8.2 to oci tests

0925709

This is the only test suite testing 8.1, so adding 8.2 as well Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Catch deprecation warnings in oci tests

ac5df8e

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Try fixing Oracle

c27c9fa

Signed-off-by: Joas Schilling <coding@schilljs.com>

Make sure name and path are strings

4bdc583

Otherwise Oracle returns NULL for empty strings and PHP 8.2 throws on null in string functions like trim() and md5() Signed-off-by: Joas Schilling <coding@schilljs.com>

nickvergessen force-pushed the enh/allow-php-8.2 branch from b095999 to 4bdc583 Compare February 2, 2023 11:05

blizzz merged commit 970f393 into master Feb 2, 2023

blizzz deleted the enh/allow-php-8.2 branch February 2, 2023 12:47

come-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed pending documentation This pull request needs an associated documentation update 3. to review Waiting for reviews labels Feb 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Allow php 8.2#36375

Allow php 8.2#36375
blizzz merged 5 commits intomasterfrom
enh/allow-php-8.2

come-nc commented Jan 26, 2023 •

edited

Loading

Uh oh!

ChristophWurst commented Jan 26, 2023

Uh oh!

ChristophWurst left a comment

Uh oh!

come-nc commented Jan 26, 2023

Uh oh!

ChristophWurst commented Jan 26, 2023

Uh oh!

nickvergessen left a comment

Uh oh!

come-nc commented Feb 2, 2023

Uh oh!

nickvergessen commented Feb 2, 2023

Uh oh!

nickvergessen commented Feb 2, 2023

Uh oh!

DaphneMuller commented Feb 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

come-nc commented Jan 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

ChristophWurst commented Jan 26, 2023

Uh oh!

ChristophWurst left a comment

Choose a reason for hiding this comment

Uh oh!

come-nc commented Jan 26, 2023

Uh oh!

ChristophWurst commented Jan 26, 2023

Uh oh!

nickvergessen left a comment

Choose a reason for hiding this comment

Uh oh!

come-nc commented Feb 2, 2023

Uh oh!

nickvergessen commented Feb 2, 2023

Uh oh!

nickvergessen commented Feb 2, 2023

Uh oh!

DaphneMuller commented Feb 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

come-nc commented Jan 26, 2023 •

edited

Loading