Conversation
Merged
Merged
|
Thanks for this PR it helps me to identify the problem I don't understand why there is a try..catch without log |
Merged
szaimen
reviewed
Apr 15, 2023
Member
Author
|
@nickvergessen I think the CI/CD errors are not related to these changes, right? So could we merge this? |
Member
I would recommend to rebase, to proof it.
No, missing 2 approvals |
szaimen
approved these changes
Apr 17, 2023
Contributor
szaimen
left a comment
There was a problem hiding this comment.
Fine by me then but didnt test
0db36d8 to
e4aea28
Compare
Member
Author
|
The only test currently failing is Would assume this is not related to the current change? |
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
Member
Author
|
Any chance to get this minor change merged, please? |
nickvergessen
approved these changes
May 23, 2023
Member
|
CI fail is known and unrelated. |
Signed-off-by: Robin Windey <ro.windey@gmail.com>
e4aea28 to
1dcc855
Compare
Contributor
|
CI failure unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Write a log message via
error_login case we can't regularly write to our logfile. This improves troubleshooting.Use case
Example:
We forgot to install the
php-apcumodule but configured it inconfig.php. This could happen for example when upgrading the PHP version or when not properly reading the manual.Before:
When trying to access NC, we're presented with a generic error message.
Neither
nextcloud.lognor/var/log/apache2/error.log(or something similar) is written. As an admin we absolutely don't know what's going on (Btw: I only solved this by debugging via XDebug).After:
There is a log entry in
/var/log/apache2/error.logtelling us:This is not formatted nicely but it tells the admin what's the problem and why the NC server instance is down.
Checklist