Fix calendar emails to be outlook compatible#36118
Conversation
|
@miaulalala would this be realistic to finish for 26? |
|
Questionable if symfony supports this: symfony/symfony#44557 I will look into it tomorrow |
f7a53e7 to
cfa3473
Compare
|
The attachment is embedded now, but I have no outlook client to test this. @merlinwoff can you please try? |
|
The rebase went sideways |
9842ac2 to
460a8b2
Compare
Signed-off-by: Anna Larch <anna@nextcloud.com>
ac79181 to
ed70815
Compare
nickvergessen
left a comment
There was a problem hiding this comment.
Please mention in the 27 changes issue
| * @param string|null $contentType MIME Content-Type (e.g. text/plain or text/calendar) | ||
| * | ||
| * @return IMessage | ||
| * @since 26.0.0 |
| * @return IMessage | ||
| * @since 26.0.0 | ||
| */ | ||
| public function attachInline(string $body, string $name, string $contentType = null): IMessage; |
There was a problem hiding this comment.
?string $contentType = null
|
Hello! Are you familiar with our documentation process already? Changes that affect administrators should be documented here: While I understand sometimes it's handy to merge fast to get your changes in, it would be great if next time you could try to add the documentation before merging. You can find more information on that here: If all your documentation efforts are done, please remove the label 'documentation' and check the checkbox in your opening note and I'll stop bugging you :) Many thanks in advance and thanks again for your work! |
Summary
Resubmit and formatted version of #34324
Checklist