Skip to content

Fix contact photos after #32057#36110

Closed
Pytal wants to merge 2 commits intomasterfrom
fix/contacts-menu-photos
Closed

Fix contact photos after #32057#36110
Pytal wants to merge 2 commits intomasterfrom
fix/contacts-menu-photos

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Jan 12, 2023

Followup to #32057

UID X-NEXTCLOUD-UID
Before #32057 John Not set
After #32057 bf2b3dc13e308eafc1bb824842d3ab91 John
Before After
image image

@Pytal Pytal added this to the Nextcloud 26 milestone Jan 12, 2023
@Pytal Pytal self-assigned this Jan 12, 2023
@Pytal Pytal mentioned this pull request Jan 12, 2023
Merged
@szaimen
Copy link
Contributor

szaimen commented Jan 12, 2023

/backport to stable25

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 12, 2023
@Pytal
Fix contact photos
e15add8 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the fix/contacts-menu-photos branch from f01c2e1 to e15add8 Compare January 12, 2023 17:58
nickvergessen
nickvergessen reviewed Jan 12, 2023
View reviewed changes
@nickvergessen
Map the X-NEXTCLOUD-UID contact property to the UID property of IEntry
39f6818 
This restores the previous behaviour from before
#32057

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the fix/contacts-menu-photos branch from de23a76 to 39f6818 Compare January 12, 2023 20:14
@nickvergessen nickvergessen mentioned this pull request Jan 12, 2023
Merged
@nickvergessen
Copy link
Member

nickvergessen commented Jan 12, 2023

In my commit I also remapped the UID of IEntry to return the user id again, to avoid breaking change of the API and all IProviders.
#32057 (comment)

@nickvergessen
Copy link
Member

nickvergessen commented Jan 12, 2023

Avatar menus still don't work. They return 404 on the POST findOne request.
The addressbook search used by the ContactsMenu\Manager does not return an entry anymore.
At this point I wonder if it would be better to revert #32057 and have a look for another or complete fix with @miaulalala

@nickvergessen nickvergessen added 3. to review Waiting for reviews and removed 4. to release Ready to be released and/or waiting for tests to finish labels Jan 12, 2023
@Pytal
Copy link
Member Author

Pytal commented Jan 12, 2023

Avatar menus still don't work. They return 404 on the POST findOne request. The addressbook search used by the ContactsMenu\Manager does not return an entry anymore. At this point I wonder if it would be better to revert #32057 and have a look for another or complete fix with @miaulalala

Contact actions are also broken, reverting #32057 first sounds good then

@Pytal Pytal mentioned this pull request Jan 13, 2023
Merged
@Pytal
Copy link
Member Author

Pytal commented Jan 13, 2023

Revert in #36131

@ChristophWurst ChristophWurst marked this pull request as draft January 13, 2023 07:18
@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@szaimen
Copy link
Contributor

szaimen commented Mar 20, 2023

Not sure if this is needed after b38d2da

@Pytal
Copy link
Member Author

Pytal commented Mar 27, 2023

Not sure if this is needed after b38d2da

This was to fix some bugs after #32057 but is not needed anymore since it was reverted in #36131

@Pytal Pytal changed the title Fix contact photos Fix contact photos after #32057 Mar 27, 2023
@Pytal Pytal closed this Mar 27, 2023
@ChristophWurst ChristophWurst deleted the fix/contacts-menu-photos branch March 28, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@miaulalala miaulalala Awaiting requested review from miaulalala

@artonge artonge Awaiting requested review from artonge

@tcitworld tcitworld Awaiting requested review from tcitworld

@hamza221 hamza221 Awaiting requested review from hamza221 hamza221 will be requested when the pull request is marked ready for review hamza221 is a code owner

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski will be requested when the pull request is marked ready for review SebastianKrupinski is a code owner

Assignees

@nickvergessen nickvergessen

@Pytal Pytal

Labels

3. to review Waiting for reviews bug feature: contacts menu feature: contacts regression

Projects

None yet

Milestone

Nextcloud 27

Development

Successfully merging this pull request may close these issues.

8 participants

@Pytal @szaimen @nickvergessen @tcitworld @artonge @ChristophWurst @blizzz @skjnldsv