Only expose storage location to admins#36094
Conversation
|
/backport to stable25 |
|
Now it's also for group admins, is that good enough, or should we wrap with an additional |
|
@nickvergessen it's for admins and group admins I've retested with admins and can confirm |
|
ah, got it. should we exclude group admins. not sure... |
|
I would say they also don't need it. Without system access there is no use of the value 🤔 |
|
I agree groupadmin are not sysadmin, they should not see the value. |
0d3945f to
141dfc9
Compare
|
here we go, fixed, rebased, squashed now only admins see the location |
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Vincent Petry <vincent@nextcloud.com>
7412381 to
c24884d
Compare
|
ok, I've added an assert, squashed, rebased |
|
@come-nc @nickvergessen can you approve or are there further concerns ? I've made it admin-only to see the storage location, not subadmins any more |
|
/backport to stable24 |
|
/backport to stable23 |
Checklist