Single block for PHP Mod not installed error#36
Merged
williambargentball merged 1 commit intonextcloud:masterfrom Jun 10, 2016
williambargentball:master
Merged
Single block for PHP Mod not installed error#36williambargentball merged 1 commit intonextcloud:masterfrom williambargentball:master
williambargentball merged 1 commit intonextcloud:masterfrom
williambargentball:master
Conversation
Member
|
@williambargent Thank you for the pull request! I need to point out that our guide lines are that you need to have two reviewers giving their 👍 before merging. Now the change is not critical, but please keep in mind for the future :) 🌞 @jancborchardt fyi |
Member
Author
|
Sorry, wasn't aware. |
Member
|
No prob :) |
Member
|
Um @williambargent can you show a before-after screenshot of this? It’s likely this was intentional and the removal of the rule has unintended side-effects. For a design pull request, please always provide screenshots. And yep – again, there need to be 2 reviews of others. cc @nextcloud/designers |
8 tasks
9 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groups the PHP Mod not installed errors on installation into one block.