Format of Databasehost for Sockets#35884
Closed
obel1x wants to merge 3 commits intonextcloud:masterfrom
obel1x:master
Closed
Format of Databasehost for Sockets#35884obel1x wants to merge 3 commits intonextcloud:masterfrom obel1x:master
obel1x wants to merge 3 commits intonextcloud:masterfrom
obel1x:master
Conversation
Makes the installer accept Unix- Sockets directly. Signed-off-by: Daniel Pd <obel1x@web.de>
the format of unix-sockets needs to be localhost:socketfile Signed-off-by: Daniel Pd <obel1x@web.de>
Author
Contributor
|
Thank you @obel1x |
Functionality also implemented in ConnectionFactory. Signed-off-by: Daniel Pd <obel1x@web.de>
Author
|
turned out to be more tricky, as the value is written to config and needs to be read from there in the same style. So now it should both work in config which makes it more styled like in other configs and better for new users. Those should both work e.g.:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First, the Documentation was wrong for the dbhost in config.php when using sockets and second, made the installer accept the filename without adding "localhost:" in front, which is uncommon so not intuitive and not documented.
TODO
nothing.
Checklist
X Code is properly formatted
X Sign-off message is added to all commits