fix(session): Always setup the session if a session cookie is passed#35866
Merged
juliusknorr merged 1 commit intomasterfrom Dec 22, 2022
Merged
fix(session): Always setup the session if a session cookie is passed#35866juliusknorr merged 1 commit intomasterfrom
juliusknorr merged 1 commit intomasterfrom
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
4 tasks
juliusknorr
added a commit
to nextcloud/text
that referenced
this pull request
Dec 22, 2022
Until nextcloud/server#35866 is merged Signed-off-by: Julius Härtl <jus@bitgrid.net>
ChristophWurst
approved these changes
Dec 22, 2022
skjnldsv
approved these changes
Dec 22, 2022
juliusknorr
added
4. to release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fix for #28311 as the merge has shown failures in E2E tests of text.
The issue is that the test pass both a session cookie as well as basic auth which then leads to the session not being opened. If a session cookie is present however we should always proceed with the previous behaviour to setup the session.