Fix svg images not supported by imaginary autorotate#35823
Closed
grusch-it wants to merge 1 commit intonextcloud:masterfrom
Closed
Fix svg images not supported by imaginary autorotate#35823grusch-it wants to merge 1 commit intonextcloud:masterfrom
grusch-it wants to merge 1 commit intonextcloud:masterfrom
Conversation
Signed-off-by: Michael Gruschwitz <[email protected]>
szaimen
added
bug
3. to review
szaimen
requested review from
a team,
ArtificialOwl,
blizzz,
come-nc,
pulsejet and
st3iny
and removed request for
a team
st3iny
approved these changes
Dec 19, 2022
Member
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
IMO, this workaround seems a bit hacky. However, SVGs don't have exif metadata so the autorotate step is obsolete anyway.
LGTM!
come-nc
requested changes
Dec 20, 2022
Merged
Merged
Merged
Member
|
Conflicts to be solved after #36546 |
Contributor
|
Svg should work correctly already |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pull request #31829 added the
autorotateoperation as first operation sent to imaginary. For svg images, this will fail with the following error messages:Error while processing the image: VIPS cannot save to "svg"Error while processing the image: Unsupported image output typeAs soon as the
autorotateoperation is removed from the imaginary pipeline, the svg image is correctly resized (fit) and converted to an jpeg image.This PR skips the
autorotateoperation if the mime type of the image is:image/svg+xmlor
image/svgAdditional notes
The imaginary
pipelineAPI operation has an optionignore_failurefor each operation. If this option is enabled for an operation, that operation should fail silently and the pipeline would continue with the next operation without failing.Unfortunately that did not work for me.