Replace custom tooltips with native one in vue components and views#35655
Merged
JuliaKirschenheuter merged 1 commit intomasterfrom Jan 9, 2023
Conversation
c80375e to
83a7f48
Compare
83a7f48 to
0a2a386
Compare
0a2a386 to
656ca59
Compare
ChristophWurst
approved these changes
Dec 14, 2022
Contributor
Author
|
/backport to stable25 |
Pytal
approved these changes
Dec 14, 2022
d93160d to
595820a
Compare
595820a to
00ee2a1
Compare
00ee2a1 to
2d7da0d
Compare
Contributor
Author
|
I think we can merge this PR even if it needs a release of NC Vue. Changes from nextcloud-libraries/nextcloud-vue#3569 are relevant for correct showing of native tooltips but also causes no errors without released NC Vue. I've put a checkbox #35654 (comment) and will reopen this issue as far this PR got merged. |
Member
|
vue component has been released with fix, v.7.3.0 |
Member
|
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2d7da0d to
1063fbc
Compare
Member
|
rebased and recompiled |
1 task
5 tasks
Member
|
FYI this caused a regression affecting master and all versions (v26, v25): #38157 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35654
Before example:
After example:
Summary
Checklist