Conversation
This reverts commit a0266d1. Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
requested review from
AndyScherzinger,
JuliaKirschenheuter,
PVince81,
skjnldsv and
szaimen
skjnldsv
approved these changes
Dec 3, 2022
szaimen
approved these changes
Dec 3, 2022
szaimen
added
4. to release
Contributor
|
@Pytal can you please check if phpunit failure is related? |
Contributor
|
I think PHPunit failure is unrelated |
Member
|
Good stuff @Pytal, thank you so much! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert #35315 first before adding new variable in #35549 after discussions with @skjnldsv for cleaner git history
No backport needed as this has already been reverted on
stable25in #35454Followup after this to add back new primary and border colors with increased contrast in #35549