[stable25] fix the popovermenu

[backportbot-nextcloud]

• ⚠️ This backport had conflicts and is incomplete

backport of #35484

[szaimen]

/compile amend /

[blizzz]

moving to 25.0.3

[szaimen]

/rebase

[rotdrop]

IMHO, the changes to apps.scss break file-actions which use an img-tag for their icons: the width is now 0, what remains is two times the padding which only makes for 28px instead of the necessary 44px.

[szaimen]

Hi, did you already test 25.0.3 (which is not out yet)? This PR should actually fix the issue and not introduce it...

[rotdrop]

I actually testing on a modified version of the current stable25 branch. I'll recheck with an unmodified version and come to it. What I see is that removing the dimensions of the img tag make it size 0. But as I said, I'd better recheck that. There two different "icon-providers" in the file-actions menu, the correctly working ones use a span:

<a href="#" class="menuitem action action-download permanent" data-action="Download">
    <span class="icon icon-download"></span>
    <span>Herunterladen</span>
/a>

The other ones have an img tag:

<a href="#" class="menuitem action action-mount-archive permanent" data-action="mount-archive">
  <img class="icon" src="/core/img/actions/external.svg">
  <span>Archiv einhängen</span>
</a>

In my view the img has width and height 16px and a padding of 14px. Now, as we have box-sizing=border-box the actual width is then set to 0 and just the padding remains.

I recheck with some vanilla stable25 branch first ...

[szaimen]

Hm... If that should be reproducible, can you open a new bug report with up-to-date information? Thanks!

[rotdrop]

Hm... If that should be reproducible, can you open a new bug report with up-to-date information? Thanks!

Yes, I'll do.