Update rich-workspace visibility

[luka-nextcloud]

With the new flow to create rich workspace Readme files described in nextcloud/text#3209 we need a hook to be able to show or hide the entry in the new files menu depending on the current folder. For that reason this PR adds a callback that can be provided to show/hide when the menu is shown.

Required for nextcloud/text#3291

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[juliusknorr]

There is one more thing that I haven't thought of upfront that would be that we don't need an input for the folder description. The new file action should trigger directly on click.

Something like this seems to do the trick there:

diff --git a/apps/files/js/newfilemenu.js b/apps/files/js/newfilemenu.js
index e38801ac6b4..1d618a1a8c6 100644
--- a/apps/files/js/newfilemenu.js
+++ b/apps/files/js/newfilemenu.js
@@ -81,10 +81,18 @@
                        if (action === 'upload') {
                                OC.hideMenus();
                        } else {
-                               event.preventDefault();
-                               this.$el.find('.menuitem.active').removeClass('active');
-                               $target.addClass('active');
-                               this._promptFileName($target);
+                               var actionItem = _.filter(this._menuItems, function(item) {
+                                       return item.id === action
+                               }).pop();
+                               if (typeof actionItem.useInput === 'undefined' || actionItem.useInput === true) {
+                                       event.preventDefault();
+                                       this.$el.find('.menuitem.active').removeClass('active');
+                                       $target.addClass('active');
+                                       this._promptFileName($target);
+                               } else {
+                                       actionItem.actionHandler();
+                                       OC.hideMenus();
+                               }
                        }
                },

@@ -204,7 +212,8 @@
                                fileType: actionSpec.fileType,
                                actionHandler: actionSpec.actionHandler,
                                checkFilename: actionSpec.checkFilename,
-                               shouldShow: actionSpec.shouldShow || (() => true)
+                               shouldShow: actionSpec.shouldShow,
+                               useInput: actionSpec.useInput,
                        });
                },

[max-nextcloud]

All in all looks good. Just one confusion with the shouldShow parameter.

[max-nextcloud]

Nice to see this finalized.
I still disagree about the way shouldShow is handled. But there's no point in arguing about this forever.

[juliusknorr]

Failures unrelated.