Merged
Conversation
471562c to
7222a28
Compare
Contributor
Author
Cannot reproduce locally. |
CarlSchwan
approved these changes
Nov 24, 2022
Contributor
|
/rebase |
7222a28 to
34b9dee
Compare
34b9dee to
21b93d6
Compare
Contributor
Author
Last CI run failed with the same error message like before 😨 I wonder how binding the console port could fail when the console is not even exposed to the network. Pushed another change to generate a random port console (9001) too. |
e296a35 to
2a51453
Compare
To avoid casual test failures. Concurrent jobs may try to use the same port forwarding for the minio container. Signed-off-by: Daniel Kesselberg <[email protected]>
2a51453 to
cddc753
Compare
Contributor
Author
|
Hey, pushed another commit and updated the description. |
icewind1991
approved these changes
Nov 30, 2022
Contributor
Author
|
/backport to stable25 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The test matrix (https://github.com/nextcloud/server/blob/master/.github/workflows/s3-primary.yml) defines two jobs. Both require and define a minio service to run the tests.
Because the jobs run within the same docker network and the same github runner, only one minio instance can use port 9000.
First approach
Using a random port for minio to avoid conflicts.
Random ports are not a solution because there is a chance that the same random port is assigned. Sounds unlikely but happend here for multiple test runs.
Second approach
Use
jobs.<job_id>.containerworks, but makes it impossible to fetch the dockers logs for the minio container.Third approach
Set
max-parallelto 1 to execute the jobs sequential.TODO
Checklist