Compute notification parsed subject from rich subject when possible

[come-nc]

Let’s avoid duplicated code and translation strings and ease application developpers lives.

[ChristophWurst]

Could you please elaborate on the problem and the solution? :)

[come-nc]

Could you please elaborate on the problem and the solution? :)

Both activity event and notification expects applications to give both a rich subject and a parsed subject, and same thing for message.
But the parsed version can be computed from the rich one in most instances, and it’s already done in several part of our code, with duplicated code.

Also, when doing this:

$event->setParsedSubject($this->l->t('%1$s commented', [$author['name']]))
->setRichSubject($this->l->t('{author} commented'), ['author' => $author]);

Two strings are created for translators to translate, while they contain the same translatable text.

This PR attempts to remove the duplicated code and strings by providing a suitable fallback in notification and activity event directly.

[come-nc]

(putting this back to developing, I’ll look into Joas feedback and special cases next week)

[come-nc]

/rebase

[come-nc]

@CarlSchwan @ChristophWurst @miaulalala I need a codeowner approval here 🙏

[ChristophWurst]

🤞

[come-nc]

There were 4 failures:
263	
264	1) OCA\Comments\Tests\Unit\Notification\NotifierTest::testPrepareSuccess
265	Expectation failed for method name is "setParsedSubject" when invoked 1 time(s).
266	Method was expected to be called 1 times, actually called 0 times.
267	
268	2) OCA\Comments\Tests\Unit\Notification\NotifierTest::testPrepareSuccessDeletedUser
269	Expectation failed for method name is "setParsedSubject" when invoked 1 time(s).
270	Method was expected to be called 1 times, actually called 0 times.
271	
272	3) OCA\DAV\Tests\unit\CalDAV\Activity\Provider\BaseTest::testSetSubjects with data set #0 ('abc', array(), 'abc')
273	Expectation failed for method name is "setParsedSubject" when invoked 1 time(s).
274	Method was expected to be called 1 times, actually called 0 times.
275	
276	4) OCA\DAV\Tests\unit\CalDAV\Activity\Provider\BaseTest::testSetSubjects with data set #1 ('{actor} created {calendar}', array(array('abc'), array('xyz')), 'abc created xyz')
277	Expectation failed for method name is "setParsedSubject" when invoked 1 time(s).
278	Method was expected to be called 1 times, actually called 0 times.

[DaphneMuller]

hello @come-nc ,
Thank you for your work on this pull request! This ticket seems to have the tag 'missing documentation', is there any chance you could clarify what documentation is missing? Is this for admins or for app developers?