fix encryption wrapper filesize for non existing files#34607
Merged
Conversation
icewind1991
requested review from
a team,
CarlSchwan,
PVince81 and
come-nc
and removed request for
a team
Member
|
/rebase |
nextcloud-command
force-pushed
the
encryption-size-not-found
branch
from
9f4375c to
fb5ff8f
Compare
artonge
reviewed
Dec 19, 2022
Merged
Merged
Merged
come-nc
requested changes
Mar 21, 2023
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
I think it should return false instead, since this is what is returned when filesize fails on local storage.
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
encryption-size-not-found
branch
from
fb5ff8f to
15a6920
Compare
Member
Author
done |
come-nc
approved these changes
Apr 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robin Appelman [email protected]